Hey everyone, we (Apollon, Sascha and myself) have uncovered several issues on our road to the 3.0.0beta1 Release. Following you will find a quick writeup of our findings - most need to be addressed. Several things have changed between 2.16 and 3.0 which break the devel/release script and/or "make distcheck" in one way or another.
*AM_MAINTAINER_MODE Patch breaks the out-of-tree-build* This commit[1] has introduced AM_MAINTAINER_MODE but now "make distcheck" (from the devel/release script) breaks in an out-of-tree build because the file vcs-version is missing. Apollon has already taken a look at it and provided a PR [2] and it needs to be reviewed. Thank you for quick help. *Overly long lines in QA and unit tests* The 2to3 migration created some lines which are too long for the Python standard of 80 chars, examples: test/py/ganeti.rapi.client_unittest.py:165 test/py/ganeti.rpc_unittest.py:402 test/py/ganeti.utils.version_unittest.py:59 test/py/ganeti.utils.version_unittest.py:62 qa/qa_job_utils.py:286 qa/qa_rapi.py:406 Instead of using the distcheck to find these we should check the whole repository at once to find all "line too long" problems and fix them in a single PR. We should also ensure these problems are found by "make pylint" and include that in the Github Actions workflow to find these problems earlier. Sidenote: neither pylint nor pep8 were installed on my testsystem, "make distcheck" seems to use some separate magic to detect overly long lines but I have not yet looked into that. *Wrong link in the 3.0 NEWS file* We cherry-picked the NEWS file from this [3] branch but it contains a typo in the Github Issue link in the first paragraph (the rst-target link does not work, the numbers of the issue ID are flipped). Easy to fix, just here for completeness *The release script needs LC_ALL=C* The script assumes the locale to be set to "C". It will fail (at least through the check-news script) when the locale is set to anything else. This situation could be improved (probably in more than one way). *Python 3 error in check-news* This slipped through the 2to3 migration and has already fixed in the current master branch with this commit [4] (but it is mentioned here for completeness). I guess thats it for now. Feel free to open PRs for the above mentioned issues or help reviewing them, as they pour in :-) Cheers, Rudi [1] https://github.com/ganeti/ganeti/commit/edc49e6a420b8b01517f0900452c6919375e5ca0 [2] https://github.com/ganeti/ganeti/pull/1465 [3] https://github.com/ganeti/ganeti/tree/prepare-3.0 [4] https://github.com/ganeti/ganeti/commit/f662d3553503ffab934184c56c26ebd1960a96a9 -- Rudolph Bott - [email protected] Telefon: +49 (0)211-63 55 56-41 Telefax: +49 (0)211-63 55 55-22 sipgate GmbH - Gladbacher Str. 74 - 40219 Düsseldorf HRB Düsseldorf 39841 - Geschäftsführer: Thilo Salmon, Tim Mois Steuernummer: 106/5724/7147, Umsatzsteuer-ID: DE219349391 www.sipgate.de - www.sipgate.co.uk -- You received this message because you are subscribed to the Google Groups "ganeti-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/ganeti-devel/CAPG4N%3DYwhFk1LypxDiwzO6BKfdw9uYNkLeVRhyUSh49UsXYe7g%40mail.gmail.com.
