Hi Rudi,
On Mon, 25 May 2020, Rudolph Bott wrote:
Following you will find a quick writeup of our
findings
Thanks a lot for writing up.
*Overly long lines in QA and unit tests*
...
earlier. Sidenote: neither pylint nor pep8 were installed on my testsystem,
"make distcheck" seems to use some separate magic to detect overly long
lines but I have not yet looked into that.
This script checking for long lines is autotools/check-python-code. It is
called from the "LC_ALL=C make check-local" target. Which already needs
setting the locale.
After hacking away two errors, where .github/ and .github/workflows/ is
not in Makefile.am, it unveils the long lines:
lib/hypervisor/hv_kvm/__init__.py:176: raise(RuntimeError("QMP
decorator could not find a valid ganeti instance object"))
lib/hypervisor/hv_kvm/__init__.py:2557: max_bandwidth_in_bytes =
instance.hvparams[constants.HV_MIGRATION_BANDWIDTH] * 1024 * 1024
lib/hypervisor/hv_kvm/__init__.py:2558:
self.qmp.SetMigrationParameters(max_bandwidth_in_bytes,
instance.hvparams[constants.HV_MIGRATION_DOWNTIME])
lib/hypervisor/hv_kvm/__init__.py:2562:
self.qmp.SetMigrationCapabilities(migration_caps.split(_MIGRATION_CAPS_DELIM))
lib/hypervisor/hv_kvm/__init__.py:2611:
migration_status.transferred_ram = query_migrate["ram"]["transferred"]
Longest line in lib/hypervisor/hv_kvm/__init__.py is longer than 80
characters
qa/qa_job_utils.py:286: raise
self._exc_info[0](self._exc_info[1]).with_traceback(self._exc_info[2])
Longest line in qa/qa_job_utils.py is longer than 80 characters
qa/qa_rapi.py:406: missing_params = [x for x in params_of_interest if x
not in info and x not in exceptions]
Longest line in qa/qa_rapi.py is longer than 80 characters
test/py/ganeti.rapi.client_unittest.py:165: for name in [s for s in
dir(client) if (s.startswith("ECODE_") and s != "ECODE_ALL")]:
Longest line in test/py/ganeti.rapi.client_unittest.py is longer than 80
characters
test/py/ganeti.rpc_unittest.py:402: self.assertEqual(res(nodes,
NotImplemented), list(zip(nodes, addresses, nodes)))
Longest line in test/py/ganeti.rpc_unittest.py is longer than 80
characters
Found 5 problem(s) while checking code.
The known one introduced and fixed in stable-2.16 are excluded.
Thanks, Sascha.
--
You received this message because you are subscribed to the Google Groups
"ganeti-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/ganeti-devel/alpine.DEB.2.20.2005252229001.4126%40ivy.loc.
