I just noticed a small mistake in the rpm spec file for the ganglia
monitoring core.  In the build section, configure is executed with
prefix set to $RPM_BUILD_ROOT/usr.  It should actually be executed with
the real prefix defined:

./configure --prefix=/usr

and later in the install section, you should do:

make install prefix=$RPM_BUILD_ROOT/usr

Usually I define a prefix variable at the top so I only have to
reference the real /usr path once in the spec file:

%define prefix /usr

Keeping it the way it is now can potentially cause the code to be
compiled with the wrong prefix defined internally.  I did a quick check
and right now it seems that only one file gets the wrong path.  The
/usr/lib/libganglia.la file has this in it:

libdir='/tmp/ganglia-monitor-core-2.4.1-buildroot/usr/lib'


I would also suggest including a default /etc/gmond.conf file in the
package as well.

Since I am making suggestions about rpm spec files, could I ask that
future versions of the gmetad package install into /usr instead of
/usr/local.  I really don't like it when rpms install files outside of
their standard paths.

~Jason


-- 
/------------------------------------------------------------------\
|  Jason A. Smith                         Email:  [EMAIL PROTECTED]  |
|  Atlas Computing Facility               Phone:  (631)344-4226    |
|  Brookhaven National Lab, Bldg. 510M    Fax:    (631)344-7616    |
|  Upton, NY 11973-5000                                            |
\------------------------------------------------------------------/


Reply via email to