Hi guys:

The following changes is preventing the correct gridstack from being
passed around (and thus preventing gridwalk from working correctly):

http://ganglia.svn.sourceforge.net/viewvc/ganglia/branches/monitor-core-3.0-beta/web/header.php?r1=790&r2=789&pathrev=790

Checking whether the cookie is set is an insufficient check because it
is possible for $gridstack_str to change.  Therefore, the correct way
to prevent the cookie from being set all the time is:

Index: header.php
===================================================================
--- header.php  (revision 1139)
+++ header.php  (working copy)
@@ -53,8 +53,7 @@
    {
       # Use cookie so we dont have to pass gridstack around within this site.
       # Cookie values are automatically urlencoded. Expires in a day.
-      $gscookie = $_COOKIE["gs"];
-      if (! isset($gscookie))
+      if ( !isset($_COOKIE["gs"]) or $_COOKIE["gs"] != $gridstack_str )
             setcookie("gs", $gridstack_str, time() + 86400);
    }

Can you guys please confirm this still solves the original issue you
were encountering?

Thanks,

Bernard

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers

Reply via email to