The following proposed patch for stable 3.1, removes all references to C++
as a supported language for building DSO metrics as it was reportedly not
working.

The changes required to get mod_example.c to compile using the GNU C++
compiler (which are rather intrusive) are already committed in trunk and
proposed for integration for the next release.

Contains changes from r1490.

Carlo
---
Index: gmond/gmond.c
===================================================================
--- gmond/gmond.c       (revision 1496)
+++ gmond/gmond.c       (working copy)
@@ -1637,7 +1637,7 @@
            delegated to an alternate module interface
         */
         modLanguage = cfg_getstr(module, "language");
-        if (modLanguage && strcasecmp(modLanguage, "C/C++")) 
+        if (modLanguage && strcasecmp(modLanguage, "c")) 
             continue;
 
         modPath = cfg_getstr(module, "path");
Index: gmond/conf.pod
===================================================================
--- gmond/conf.pod      (revision 1496)
+++ gmond/conf.pod      (working copy)
@@ -358,17 +358,17 @@
 section contains at least one B<module> section.  Within a B<module> section
 are the directives B<name>, B<language>, B<path> and B<params>.  The module 
 B<name> is the name of the module as determined by the module structure if
-the module was developed in C/C++.  Alternatively, the B<name> can be 
+the module was developed in C.  Alternatively, the B<name> can be 
 the name of the source file if the module has been implemented in a 
 interpreted language such as python.  A B<language> designation must be 
 specified as a string value for each module.  The B<language> directive 
 must correspond to the source code language in which the module was 
 implemented (ex. language = "python").  If a B<language> directive does 
-not exist for the module, the assumed language will be "C/C++". The B<path> 
-is the path from which gmond is expected to load the module (C/C++ compiled 
+not exist for the module, the assumed language will be "c". The B<path> 
+is the path from which gmond is expected to load the module (C compiled 
 dynamically loadable module only).  The B<params> directive can be used 
 to pass a single string parameter directly to the module initialization 
-function (C/C++ module only). Multiple parameters can be passed to the 
+function (C module only). Multiple parameters can be passed to the 
 module's initialization function by including one or more B<param> sections. 
 Each B<param> section must be named and contain a B<value> directive. Once 
 a module has been loaded, the additional metrics can be discovered by 
@@ -377,7 +377,7 @@
    modules {
      module {
        name = "example_module"
-       language = "C/C++"
+       language = "c"
        path = "/usr/lib/ganglia/modules/modexample.so"
        params = "An extra raw parameter"
        param RandomMax {
-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers

Reply via email to