http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53028

--- Comment #11 from Mike Stump <mikestump at comcast dot net> 2012-04-30 
01:08:24 UTC ---
>> also don't test that the warning goes away with -w.  We don't test the 
>> warning
>> turns into an error with -Werror.
> 
> Don't we?
> 
> http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01778.html

Two comments.  First, this, at most can test just one case, I mean, we don't
test all cases.  Second, I don't see -Werror anywhere.  I don't see -w
anywhere.  Maybe I missed how these test these two options...

> Perhaps we can devise an indirect
> way to test that a warning is enabled by a certain option. We could have 
> { dg-warning-with-option "Wlong-long" "ISO C90 does not support 'long long'" 
> },
> which will match the option shown with -fdiagnostics-show-option. Can we at
> least have this?

I like the idea that we have a way to write one test case instead of three... 
I certainly won't object.

> Fair enough. But the duplicated testcases are still being added!

I'd rather error on the side of letting the FE people do what they want.

Reply via email to