http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55836

--- Comment #2 from Lars Hamrén <hamren at sdu dot se> 2013-01-01 00:38:27 UTC 
---
> Why not just not use -Weffc++ for STL.

I can turn it off locally using a pragma, but that is rather ugly.

I like to have as many warning flags turned on as possible. Not having false
warnings is a great help.

> effc++ warnings are written from a book
> and they don't always make sense really.

But often they do. Why not give them special treatment when they occur in
system headers?

> > If the compiler were to set a pre-processor variable when -Weffc++ is in
> > effect, adding virtual destructors could be made conditional.
> 
> Then it would violate the one definition rule.

Agreed. Bad idea.

Reply via email to