https://gcc.gnu.org/bugzilla/show_bug.cgi?id=19706

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ramana at gcc dot gnu.org
   Target Milestone|---                         |8.0

--- Comment #4 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
(In reply to Tamar Christina from comment #3)
> Author: tnfchris
> Date: Tue Aug  8 13:17:41 2017
> New Revision: 250957
> 
> URL: https://gcc.gnu.org/viewcvs?rev=250957&root=gcc&view=rev
> Log:
> 2017-08-08  Tamar Christina  <tamar.christ...@arm.com>
> 
>       PR middle-end/19706
>       * config/aarch64/aarch64.md (xorsign<mode>3): New optabs.
>       * config/aarch64/aarch64-builtins.c
>       (aarch64_builtin_vectorized_function): Added CASE_CFN_XORSIGN.
>       * config/aarch64/aarch64-simd-builtins.def: Added xorsign BINOP.
>       * config/aarch64/aarch64-simd.md: Added xorsign<mode>3.
> 
> gcc/testsuite/
> 2017-08-08  Tamar Christina  <tamar.christ...@arm.com>
> 
>       * gcc.target/aarch64/xorsign.c: New.
>       * gcc.target/aarch64/xorsign_exec.c: New.
>       * gcc.target/aarch64/vect-xorsign_exec.c: New.
> 
> 
> Added:
>     trunk/gcc/testsuite/gcc.target/aarch64/vect-xorsign_exec.c
>     trunk/gcc/testsuite/gcc.target/aarch64/xorsign.c
>     trunk/gcc/testsuite/gcc.target/aarch64/xorsign_exec.c
> Modified:
>     trunk/gcc/ChangeLog
>     trunk/gcc/config/aarch64/aarch64-simd.md
>     trunk/gcc/config/aarch64/aarch64.md
>     trunk/gcc/testsuite/ChangeLog


I would have put these testcases into gcc.dg/vect and added a
target_supports_vect_xorsign so that other targets had a fighting chance of
catching such changes.

Is this pattern relevant to AArch32 for instance ? If so I'd like to add those
patterns there for bonus points ...  

I suspect the drotg testcase is fixed up by this . If so this bug should then
be closed out as the mid-end has support for it. I'm not clear if slasv2.f is
worth  looking at further as another example.

Reply via email to