https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86713

--- Comment #3 from ktkachov at gcc dot gnu.org ---
(In reply to Vladimir Bashkirtsev from comment #2)
> Would happy oblige but GNU coding standards say "Please keep the length of
> source lines to 79 characters or less, for maximum readability in the widest
> range of environments." and this bug is caused specifically by adherence to
> this standard. Patching it with patch attached to this bug report will
> violate GNU coding standards.
> 
> Perhaps more complex patch must be applied to config.gcc to cope with
> wrapped lines.
> 
> What is your take on it?
> 
> Also I am honestly struggle with a testcase: not really sure how it can be
> tested at all (I mean by means of automated testing).

In this case the long line length is necessary for correctness, so that
wouldn't disqualify the patch. config.gcc could be made more robust, but that
would be a separate piece of work and I'm not sure if it would be worth the
complexity just to accommodate line length. The coding style is a guideline to
be followed when possible, but it shouldn't dictate the content of the patch.

There's no straightforward way to write a testcase for this as it is a GCC
build-time bug. When submitting the patch, please mention what configure
command fails before your patch and that it succeeds with your patch. That
would be strong justification for it.

Reply via email to