https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104019
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |61596
--- Comment #11 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Rimvydas (RJ) from comment #8)
> /build/trunk/x86_64-unknown-dragonfly6.3/libstdc++-v3/include/bits/
> shared_ptr_base.h: In member function 'void
> std::_Sp_counted_array_base<_Alloc>::_M_init(typename
> std::allocator_traits<_Alloc>::value_type*, _Init)':
> /build/trunk/x86_64-unknown-dragonfly6.3/libstdc++-v3/include/bits/
> shared_ptr_base.h:767: warning: typedef 'using value_type = using _Up =
> typename std::allocator_traits<_Alloc>::value_type' locally defined but not
> used [-Wunused-local-typedefs]
> /build/trunk/x86_64-unknown-dragonfly6.3/libstdc++-v3/include/bits/
> shared_ptr_base.h:768: warning: typedef 'using difference_type =
> std::ptrdiff_t' locally defined but not used [-Wunused-local-typedefs]
> /build/trunk/x86_64-unknown-dragonfly6.3/libstdc++-v3/include/bits/
> shared_ptr_base.h:771: warning: typedef 'using iterator_category = struct
> std::forward_iterator_tag' locally defined but not used
> [-Wunused-local-typedefs]
These warnings are bogus, those typedefs are not "local" because they are
members of a local class, and they are 100% necessary. This is PR 61596.
> In file included from
> /build/trunk/x86_64-unknown-dragonfly6.3/libstdc++-v3/include/x86_64-unknown-
> dragonfly6.3/bits/stdc++.h:144:
> /build/trunk/x86_64-unknown-dragonfly6.3/libstdc++-v3/include/latch: In
> member function 'void std::latch::count_down(std::ptrdiff_t)':
> /build/trunk/x86_64-unknown-dragonfly6.3/libstdc++-v3/include/latch:65:
> warning: comparison of integer expressions of different signedness: 'const
> long unsigned int' and 'std::ptrdiff_t' {aka 'long int'} [-Wsign-compare]
This would fix it, but needs checking carefully:
--- a/libstdc++-v3/include/std/latch
+++ b/libstdc++-v3/include/std/latch
@@ -60,9 +60,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
_GLIBCXX_ALWAYS_INLINE void
count_down(ptrdiff_t __update = 1)
{
+ __glibcxx_assert(__update >= 0);
+
auto const __old = __atomic_impl::fetch_sub(&_M_a,
- __update, memory_order::release);
- if (__old == __update)
+ __update,
+ memory_order::release);
+ if (__old == static_cast<__detail::__platform_wait_t>(__update))
__atomic_impl::notify_all(&_M_a);
}
Referenced Bugs:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61596
[Bug 61596] -Wunused-local-typedefs warns incorrectly on a typedef that's
referenced indirectly
