https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106624

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Martin Liska
<mar...@gcc.gnu.org>:

https://gcc.gnu.org/g:193f7e62815b4089dfaed4c2bd34fd4f10209e27

commit r12-9061-g193f7e62815b4089dfaed4c2bd34fd4f10209e27
Author: Sergei Trofimovich <siarh...@google.com>
Date:   Tue Aug 16 12:35:07 2022 +0100

    driver: fix environ corruption after putenv() [PR106624]

    The bug appeared afte r13-2010-g1270ccda70ca09 "Factor out
    jobserver_active_p" slightly changed `putenv()` use from allocating
    to non-allocating:

        -xputenv (concat ("MAKEFLAGS=", dup, NULL));
        +xputenv (jinfo.skipped_makeflags.c_str ());

    `xputenv()` (and `putenv()`) don't copy strings and only store the
    pointer in the `environ` global table. As a result `environ` got
    corrupted as soon as `jinfo.skipped_makeflags` store got deallocated.

    This started causing bootstrap crashes in `execv()` calls:

        xgcc: fatal error: cannot execute '/build/build/./prev-gcc/collect2':
execv: Bad address

    The change restores memory allocation for `xputenv()` argument.

    gcc/

            PR driver/106624
            * gcc.cc (driver::detect_jobserver): Allocate storage xputenv()
            argument using xstrdup().

    (cherry picked from commit 2b403297b111c990c331b5bbb6165b061ad2259b)

Reply via email to