https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54089
--- Comment #70 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to Alexander Klepikov from comment #69)
> Created attachment 55284 [details]
> Collapsed libcall and additional loop move invariants patch
Thanks for sharing the patch. I also don't have the GCC SH test environment
setup at the moment, so it will take me some time to get up to speed on that.
There are some formatting nits in your patch, please check again:
* don't add / remove empty lines for no reason
* '{' goes on new line (follow surrounding code style)
* in comments: two spaces after the period
* closing ')' and ']' in the RTL should go on the same line (follow surrounding
style)
But more interestingly:
* Do we really need to add that new source file sh_loop.cc with the wrapper
classes? Can't we just instantiate the passes that are needed in-place when
they are registered?
* Can you add some tests to the SH specific tests?
