2011/3/17 Jason Merrill <ja...@redhat.com>: > On 03/17/2011 12:08 PM, Kai Tietz wrote: >> >> I thought to use here instead of on_diagnostic (which is IMHO fine too >> as it indicates for now only that attribute shall be displayed on >> diagnostics) "affects_abi". I think it makes sense to keep that name >> as short as possible. > > Hmm, type compatibility is higher level than the ABI; it affects whether two > declarations are considered to be the same. I think clarity is more > important than a short name for something that shouldn't be used in that > many places. I'd prefer "affects_type_identity".
I will update the patch and using this name > And does changing comp_type_attributes to check it make sense to you? Well, in general it would, but not all of those affecting type identity in 64-bit vs. 32-bit case. Most of them affect type identity only in 32-bit, but not for 64-bit )at least so for amd64/x86). So I don't think we will profit here much. Kai
