"H.J. Lu" <hjl.to...@gmail.com> writes:

> On Fri, Jul 1, 2011 at 2:02 AM, Rainer Orth <r...@cebitec.uni-bielefeld.de> 
> wrote:
>> "H.J. Lu" <hjl.to...@gmail.com> writes:
>>
>>> Here is the updated patch.  It works on simple tests.
>>> I am running full tests.  I kept config/i386/value-unwind.h
>>> since libgcc/md-unwind-support.h is included too late
>>> in unwind-dw2.c and I don't want to move it to be on
>>> the safe side.
>>
>> Oh please, don't pile hack upon hack to avoid proper testing.
>>
>
> What is your suggestion?

How about moving the md-unwind-support.h include up to the rest of the
includes?  The headers usually only define MD_FALLBACK_FRAME_STATE_FOR
and perhaps MD_FROB_UPDATE_CONTEXT, everything else is an internal
helper macro, so order shouldn't matter.

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to