"H.J. Lu" <hjl.to...@gmail.com> writes:

>>> What is your suggestion?
>>
>> How about moving the md-unwind-support.h include up to the rest of the
>> includes?  The headers usually only define MD_FALLBACK_FRAME_STATE_FOR
>> and perhaps MD_FROB_UPDATE_CONTEXT, everything else is an internal
>> helper macro, so order shouldn't matter.
>>
>
> It doesn't work on Linux/x86-64:
>
> In file included from
> /export/gnu/import/git/gcc/libgcc/../gcc/unwind-dw2.c:39:0:
> ./md-unwind-support.h: In function \u2018x86_fallback_frame_state\u2019:
> ./md-unwind-support.h:121:30: error: dereferencing pointer to incomplete type

Then move it below the definition of struct _Unwind_Context with a
comment explaining why it has to be there.  I thought you aspired to
become Linux maintainer?

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to