thanks for the validation and the confirmation that iinline-attr.c is
now fixed on aarch64. I can now send the patch for submission request
(this one was just illustrative).
thanks
Christian
On 05/05/2015 11:10 AM, Yvan Roux wrote:
> Hi Christian,
>
> On 4 May 2015 at 11:29, Christian Bruel <christian.br...@st.com> wrote:
>>
>>> Hi Christian,
>>> I noticed case gcc.dg/ipa/iinline-attr.c failed on aarch64. The
>>> original patch is x86 specific, while the case is added as general
>>> one. Could you please have a look at this?
>>>
>>> FAIL: gcc.dg/ipa/iinline-attr.c scan-ipa-dump inline
>>> "hooray[^\\n]*inline copy in test"
>>>
>>
>> that is the same latent bug for aarch64: alignment flags are not
>> propagated with attribute optimize ("O2").
>>
>> testing attached patch
>
> The patch looks good to me, maybe you can just fix the original typo
> on "optimizing" in the comments while moving the code. I've
> bootstrapped and regtested it on aarch64-linux-gnu with the same
> target testcase you added on i386 (as we discussed offline) and
> everything is ok (gcc.dg/ipa/iinline-attr.c now PASS). Notice that I
> can't approve your patch.
>
> Cheers,
> Yvan
>
