On 10/21/2015 10:22 AM, Bernd Schmidt wrote:
On 10/21/2015 06:18 PM, Jeff Law wrote:
To avoid conditionally compiled code. I'm of the opinion we should be
stomping out as much as we reasonably can.
Yeah, I get that, but the point I'm trying to make is that if you get
rid of all conditional compilation, you don't need either
ENABLE_CHECKING or CHECKING_P, because you'll be testing flag_checking.
And if some conditional compilation remains (let's say in the
cumulative_args case), then there's no win from changing the spelling
from ENABLE_CHECKING to CHECKING_P.
But if you can't make the change as a single atomic commit, then we run
the risk of turning on checking bits when ENABLE_CHECKING is defined to 0.
CHECKING_P allows us to pursue removal of the conditionally compiled
code incrementally. Each removal of a hunk of conditionally compiled
code is possible independently of all the other removals.
jeff
