On Wed, Nov 04, 2015 at 03:15:53PM -0600, Segher Boessenkool wrote: > Hi, > > Some minor things... > > On Tue, Nov 03, 2015 at 03:29:11PM -0500, Michael Meissner wrote: > > * config/rs6000/rs6000.opt (-mfusion-toc): Add new switches for > > ISA 3.0 (power9). > > "-mtoc-fusion" sounds more natural, and is more in line with the other > switches I think.
That's reasonable. At present, -mfusion-toc is not documented, as it was intended to be a debug switch. David, do you have an opinion one way or the other? > > + /* ISA 2.08 vector instructions include ISA 2.07. */ > > ISA 3.0 Thanks for catching that. I missed a few places that were written earlier before we decided the new ISA would be 3.0 instead of 2.8. I'll make those changes before submitting. > > +@item -mmodulo > > +@itemx -mno-modulo > > +@opindex mmodulo > > +@opindex mno-module > > +Generate code that uses (does not use) the ISA 2.08 integer modulo > > +instructions. The @option{-mmodulo} option is enabled by default > > +with the @option{-mcpu=power9} option. > > Again. I think it was just these two, but please check. > > > +@item -mpower9-fusion > > +@itemx -mno-power9-fusion > > +@opindex mpower9-fusion > > +@opindex mno-power9-fusion > > +Generate code that keeps (does not keeps) some operations adjacent so > > +that the instructions can be fused together on power9 and later > > +processors. > > > +@item -mpower9-vector > > +@itemx -mno-power9-vector > > +@opindex mpower9-vector > > +@opindex mno-power9-vector > > +Generate code that uses (does not use) the vector and scalar > > +instructions that were added in version 2.07 of the PowerPC ISA. Also > > +enable the use of built-in functions that allow more direct access to > > +the vector instructions. > > 3.0 here as well? I only found 3 references to 2.08 in the patch. Thanks. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.vnet.ibm.com, phone: +1 (978) 899-4797