On 26 November 2015 at 17:10, Matthew Wahab <matthew.wa...@foss.arm.com> wrote: > Attached the missing patch. > Matthew > > > On 26/11/15 16:02, Matthew Wahab wrote: >> >> Hello, >> >> This patch adds ARMv8.1 support to GCC Dejagnu, to allow ARM >> tests to specify targest and to set up command line options. >> It builds on the ARMv8.1 target support added for AArch64 tests, partly >> reworking that support to take into account the different configurations >> that tests may be run under. >> >> The main changes are >> - add_options_for_arm_v8_1a_neon: Call >> check_effective_target_arm_v8_1a_neon_ok to select a suitable set of >> options. >> - check_effective_target_arm_v8_1a_neon_ok: Test possible command line >> options, recording the first set that works. >> - check_effective_target_arm_v8_1a_neon_hw: Add a test for ARM targets. >> >> Tested the series for arm-none-eabi with cross-compiled check-gcc on an >> ARMv8.1 emulator. Also tested arm-none-linux-gnueabihf with native >> bootstrap and make check. >> >> Ok for trunk? >> Matthew >>
Hi Matthew, I may be mistaken, but -mfpu=neon-fp-armv8 and -mfloat-abi=softfp are not supported by aarch64-gcc. So it seems to me that check_effective_target_arm_v8_1a_neon_ok_nocache will not always work for aarch64 after your patch. Or does it work because no option is needed and thus "" always matches and thus the loop always exits after the first iteration on aarch64? Maybe a more accurate comment would help remembering that, in case -mfpu option becomes necessary for aarch64. Christophe. >> testsuite/ >> 2015-11-26 Matthew Wahab <matthew.wa...@arm.com> >> >> * lib/target-supports.exp (add_options_for_arm_v8_1a_neon): Update >> comment. Use check_effetive_target_arm_v8_1a_neon_ok to select >> the command line options. >> (check_effective_target_arm_v8_1a_neon_ok_nocache): Update initial >> test to allow ARM targets. Select and record a working set of >> command line options. >> (check_effective_target_arm_v8_1a_neon_hw): Add tests for ARM >> targets. >> >
