On 27/11/15 13:44, Christophe Lyon wrote:
On 26/11/15 16:02, Matthew Wahab wrote:
This patch adds ARMv8.1 support to GCC Dejagnu, to allow ARM tests to specify targest and to set up command line options. It builds on the ARMv8.1 target support added for AArch64 tests, partly reworking that support to take into account the different configurations that tests may be run under.
I may be mistaken, but -mfpu=neon-fp-armv8 and -mfloat-abi=softfp are not supported by aarch64-gcc. So it seems to me that check_effective_target_arm_v8_1a_neon_ok_nocache will not always work for aarch64 after your patch.
Or does it work because no option is needed and thus "" always matches and thus the loop always exits after the first iteration on aarch64?
Yes, the idea is that the empty string will make the function first try '-march=armv8.1-a' without any other flag. That will work for AArch64 because it doesn't need any other option.
Maybe a more accurate comment would help remembering that, in case -mfpu option becomes necessary for aarch64.
Agreed, it's worth having a comment to explain what the 'foreach' construct is doing. Matthew
