On Tue, Dec 8, 2015 at 7:45 AM, Christian Bruel <christian.br...@st.com> wrote: > Hi Matthew, > > > On 12/07/2015 05:07 PM, Matthew Wahab wrote: >> >> Ping. Updated patch attached. >> Matthew >> >> >> On 26/11/15 16:01, Matthew Wahab wrote: >>> >>> Hello, >>> >>> This patch adds the feature macro __ARM_FEATURE_QRDMX to indicate the >>> presence of the ARMv8.1 instructions vqrdmlah and vqrdmlsh. It is >>> defined when the instructions are available, as it is when >>> -march=armv8.1-a is enabled with suitable fpu options. >>> >>> Tested the series for arm-none-eabi with cross-compiled check-gcc on an >>> ARMv8.1 emulator. Also tested arm-none-linux-gnueabihf with native >>> bootstrap and make check. >>> >>> Ok for trunk? >>> Matthew >>> >>> gcc/ >>> 2015-11-26 Matthew Wahab <matthew.wa...@arm.com> >>> >>> * config/arm/arm-c.c (arm_cpu_builtins): Define >>> __ARM_FEATURE_QRDMX. >>> >> > > + if (TARGET_NEON_RDMA) > + builtin_define ("__ARM_FEATURE_QRDMX"); > + > > Since it depends on TARGET_NEON, could you please use > > def_or_undef_macro (pfile, "__ARM_FEATURE_QRDMX", TARGET_NEON_RDMA); > > instead ?
I think that's what it should be - OK with that fixed. Ramana > > thanks > > Christian