Hi,
it's a regression present on the mainline and 6 branch: for the attached Ada
testcase, optab_for_tree_code segfaults because the function is invoked on a
NULL_TREE vectype_out from the vectorizer (vectorizable_reduction):
if (STMT_VINFO_VEC_REDUCTION_TYPE (stmt_info) == TREE_CODE_REDUCTION
|| STMT_VINFO_VEC_REDUCTION_TYPE (stmt_info)
== INTEGER_INDUC_COND_REDUCTION)
{
if (reduction_code_for_scalar_code (orig_code, &epilog_reduc_code))
{
reduc_optab = optab_for_tree_code (epilog_reduc_code, vectype_out,
optab_default);
Naive attempts at working around the NULL_TREE result in bogus vectorization
and GIMPLE verification failure so it seems clear that vectype_out ought not
to be NULL_TREE here.
The problems stems from vect_determine_vectorization_factor, namely:
/* Bool ops don't participate in vectorization factor
computation. For comparison use compared types to
compute a factor. */
if (TREE_CODE (scalar_type) == BOOLEAN_TYPE
&& is_gimple_assign (stmt)
&& gimple_assign_rhs_code (stmt) != COND_EXPR)
{
if (STMT_VINFO_RELEVANT_P (stmt_info))
mask_producers.safe_push (stmt_info);
bool_result = true;
if (gimple_code (stmt) == GIMPLE_ASSIGN
&& TREE_CODE_CLASS (gimple_assign_rhs_code (stmt))
== tcc_comparison
&& TREE_CODE (TREE_TYPE (gimple_assign_rhs1 (stmt)))
!= BOOLEAN_TYPE)
scalar_type = TREE_TYPE (gimple_assign_rhs1 (stmt));
else
{
if (!analyze_pattern_stmt && gsi_end_p (pattern_def_si))
{
pattern_def_seq = NULL;
gsi_next (&si);
}
continue;
}
}
which leaves STMT_VINFO_VECTYPE set to NULL_TREE. It would have been nice to
say in the comment why boolean operations don't participate in vectorization
factor computation; one can only assume that it's because they are somehow
treated specially, so the proposed fix does the same in vectorizable_reduction
(and is probably a no-op except for Ada because of the precision test).
Tested on x86_64-suse-linux, OK for mainline and 6 branch?
2016-05-31 Eric Botcazou <ebotca...@adacore.com>
* tree-vect-loop.c (vectorizable_reduction): Also return false if the
scalar type is a boolean type.
2016-05-31 Eric Botcazou <ebotca...@adacore.com>
* gnat.dg/opt56.ad[sb]: New test.
--
Eric BotcazouIndex: tree-vect-loop.c
===================================================================
--- tree-vect-loop.c (revision 236877)
+++ tree-vect-loop.c (working copy)
@@ -5496,13 +5496,15 @@ vectorizable_reduction (gimple *stmt, gi
scalar_dest = gimple_assign_lhs (stmt);
scalar_type = TREE_TYPE (scalar_dest);
- if (!POINTER_TYPE_P (scalar_type) && !INTEGRAL_TYPE_P (scalar_type)
+ if (!POINTER_TYPE_P (scalar_type)
+ && !INTEGRAL_TYPE_P (scalar_type)
&& !SCALAR_FLOAT_TYPE_P (scalar_type))
return false;
- /* Do not try to vectorize bit-precision reductions. */
- if ((TYPE_PRECISION (scalar_type)
- != GET_MODE_PRECISION (TYPE_MODE (scalar_type))))
+ /* Do not try to vectorize boolean or bit-precision reductions. */
+ if (TREE_CODE (scalar_type) == BOOLEAN_TYPE
+ || TYPE_PRECISION (scalar_type)
+ != GET_MODE_PRECISION (TYPE_MODE (scalar_type)))
return false;
/* All uses but the last are expected to be defined in the loop.
-- { dg-do compile }
-- { dg-options "-O3" }
package body Opt56 is
function F (Values : Vector) return Boolean is
Result : Boolean := True;
begin
for I in Values'Range loop
Result := Result and Values (I) >= 0.0;
end loop;
return Result;
end;
end Opt56;
package Opt56 is
type Vector is array (Positive range <>) of Float;
function F (Values : Vector) return Boolean;
end Opt56;
