OK with a couple of nits below.
Diego. http://codereview.appspot.com/4956041/diff/1/gcc/cp/pph-streamer-in.c File gcc/cp/pph-streamer-in.c (right): http://codereview.appspot.com/4956041/diff/1/gcc/cp/pph-streamer-in.c#newcode155 gcc/cp/pph-streamer-in.c:155: || marker == PPH_RECORD_PREF; 154 return marker == PPH_RECORD_IREF || marker == PPH_RECORD_XREF 155 || marker == PPH_RECORD_PREF; Align these vertically. http://codereview.appspot.com/4956041/diff/1/gcc/cp/pph-streamer-in.c#newcode197 gcc/cp/pph-streamer-in.c:197: || marker == PPH_RECORD_PREF) 154 return marker == PPH_RECORD_IREF || marker == PPH_RECORD_XREF 155 || marker == PPH_RECORD_PREF; Likewise. http://codereview.appspot.com/4956041/diff/1/gcc/cp/pph-streamer.c File gcc/cp/pph-streamer.c (right): http://codereview.appspot.com/4956041/diff/1/gcc/cp/pph-streamer.c#newcode530 gcc/cp/pph-streamer.c:530: enum pph_record_marker marker) 529 pph_cache_get (pph_pickle_cache *stream_cache, unsigned include_ix, unsigned ix, 530 enum pph_record_marker marker) Do we really need the MARKER argument? If STREAM_CACHE is NULL, we use INCLUDE_IX to determine if they want an external reference or the preloaded cache. Though, I guess adding MARKER does not hurt and makes the code easier to read. Never mind. http://codereview.appspot.com/4956041/