Hi, Thanks for the feedbacks. —> I’m already configuring gcc with multiple languages and multilib enabled
—> The changes have been bootstrapped and regression tested (complete check, make -k -j20 check). —> As mentioned, I have locally removed obstack.[ch] from libiberty and built and tested the entire thing. PFA the patch ChangeLog: 15-7-16 Ayush Goel <ayushgoel1...@gmail.com> * Makefile.def: Added gnulib as build & host library and dependency of all-gcc on gnulib * Makefile.in: regenerated * configure.ac: Added gnulib as build and host library * configure: regenerated * gcc/Makefile.in: Added path to gnulib static library (libgnu.a) and gnulib header files * gnulib: created directory * gnulib/Makefile.in: new file * gnulib/configure.ac: new file * gnulib/update-gnulib.sh: script to import gnulib modules using gnulib-tool * gnulib/import: created by update-gnulib.sh * gnulib/import/Makefile.in: imported from gnulib * gnulib/import/alignof.h: Imported from gnulib * gnulib/import/exitfail.c: Imported from gnulib * gnulib/import/exitfail.h: Imported from gnulib * gnulib/import/extra: Imported from gnulib * gnulib/import/extra/snippet: Imported from gnulib * gnulib/import/extra/snippet/_Noreturn.h: Imported from gnulib * gnulib/import/extra/snippet/arg-nonnull.h: Imported from gnulib * gnulib/import/extra/snippet/c++defs.h: Imported from gnulib * gnulib/import/extra/snippet/warn-on-use.h: Imported from gnulib * gnulib/import/gettext.h: Imported from gnulib * gnulib/import/m4: Imported from gnulib * gnulib/import/m4/00gnulib.m4: Imported from gnulib * gnulib/import/m4/absolute-header.m4: Imported from gnulib * gnulib/import/m4/extern-inline.m4: Imported from gnulib * gnulib/import/m4/gnulib-cache.m4: Imported from gnulib * gnulib/import/m4/gnulib-common.m4: Imported from gnulib * gnulib/import/m4/gnulib-comp.m4: Imported from gnulib * gnulib/import/m4/gnulib-tool.m4: Imported from gnulib * gnulib/import/m4/include_next.m4: Imported from gnulib * gnulib/import/m4/longlong.m4: Imported from gnulib * gnulib/import/m4/multiarch.m4: Imported from gnulib * gnulib/import/m4/obstack.m4: Imported from gnulib * gnulib/import/m4/off_t.m4: Imported from gnulib * gnulib/import/m4/ssize_t.m4: Imported from gnulib * gnulib/import/m4/stddef_h.m4: Imported from gnulib * gnulib/import/m4/stdint.m4: Imported from gnulib * gnulib/import/m4/stdlib_h.m4: Imported from gnulib * gnulib/import/m4/sys_types_h.m4: Imported from gnulib * gnulib/import/m4/unistd_h.m4: Imported from gnulib * gnulib/import/m4/warn-on-use.m4: Imported from gnulib * gnulib/import/m4/wchar_t.m4: Imported from gnulib * gnulib/import/obstack.c: Imported from gnulib * gnulib/import/obstack.h: Imported from gnulib * gnulib/import/stddef.in.h: Imported from gnulib * gnulib/import/stdint.in.h: Imported from gnulib * gnulib/import/stdlib.in.h: Imported from gnulib * gnulib/import/sys: Imported from gnulib * gnulib/import/sys_types.in.h: Imported from gnulib * gnulib/import/unistd.c: Imported from gnulib * gnulib/import/unistd.in.h: Imported from gnulib * gnulib/stamp-h1: generated Also note that I have a copyright assignment in place already. -- Thanks, Ayush Goel On 10 July 2016 at 9:35:27 PM, Manuel López-Ibáñez (lopeziba...@gmail.com) wrote: > Hi Ayush, > > Some suggestions: > > * When resubmitting a patch, also add again the Changelog. > * Use '.diff' or '.patch' as an extension, so that mail readers can > open the file as text. > * Mention that you have a copyright assignment in place already (I'm > assuming you have one already, no?). > * Mention how you regression tested your changes (on which targets?) > * In the case of these changes, and as further testing, it would be > good if you tried locally to remove obstack.[ch] from libiberty to > make sure nothing in GCC is using it. I don't think we can actually > remove it because it may be used by other projects using libiberty, > however, as your first submission showed, it is not always evident > that everything in GCC is using the gnulib version. > > Cheers, > > Manuel. > > > On 8 July 2016 at 20:30, ayush goel wrote: > > Yes, that’s correct. It has been moved before the libiberty library in the > > list now. > Bootstrapped the system with the changes as well. > > > > PFA the updated patch > > > > -- > > Thanks, > > Ayush Goel > > > > On 8 July 2016 at 2:29:04 AM, Manuel López-Ibáñez (lopeziba...@gmail.com) > > wrote: > >> On 7 July 2016 at 13:48, ayush goel wrote: > >> > In order to show the setup works, I’ve replaced libiberty’s version by > >> > obstack by > gnulib’s. > >> This was made possible by replacing the corresponding header file and then > >> including > >> gnulib headers and gnulib static library in the build path required to > >> compile gcc > files. > >> > >> Hi Ayush, > >> > >> I'm not an expert on the build machinery, so this question might be > >> misguided: How do you know it is using the version in gnulib rather > >> than the one in libiberty? I see it uses gnulib's header file but: > >> > >> # Dependencies on the intl and portability libraries. > >> LIBDEPS= libcommon.a $(CPPLIB) $(LIBIBERTY) $(LIBINTL_DEP) $(LIBICONV_DEP) > >> > \ > >> - $(LIBDECNUMBER) $(LIBBACKTRACE) > >> + $(LIBDECNUMBER) $(LIBBACKTRACE) $(LIBGNU) > >> > >> makes me think that the code in libiberty is found before the one in > >> libgnu. > >> > >> Cheers, > >> > >> Manuel. > >> >
importgnulib_7_25.patch
Description: Binary data
