Toma Tabacu <toma.tab...@imgtec.com> writes:
> The msa-builtins-err.c test is failing in the following configuration:
> -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
> This is because the errors it is checking for are triggered by assembly
> generation, which is prevented by -fno-fat-lto-objects.
> 
> This patch fixes this by adding a dg-skip-if for -fno-fat-lto-objects.
> 
> Tested with mips-mti-elf.
> 
> Regards,
> Toma Tabacu
> 
> gcc/testsuite/ChangeLog:
> 
>       * gcc.target/mips/msa-builtins-err.c (dg-skip-if): Do not run the test
>       if -fno-fat-lto-objects is present.

You don't need the (dg-skip-if) here, no specific reason but people
don't tend to do it.

It's a shame this is the only way to deal with this but I see aarch64 have
to resort to the same thing for error checking tests.

Thanks for the fix, OK to commit.

Matthew

Reply via email to