Committed as r243639. Regards, Toma
> -----Original Message----- > From: Matthew Fortune > Sent: 13 December 2016 13:46 > To: Toma Tabacu; gcc-patches@gcc.gnu.org > Cc: catherine_mo...@mentor.com > Subject: RE: [PATCH, testsuite] MIPS: Skip msa-builtins-err.c if there is no > assembly output. > > Toma Tabacu <toma.tab...@imgtec.com> writes: > > > > > > It's a shame this is the only way to deal with this but I see aarch64 > > > have to resort to the same thing for error checking tests. > > > > > > > I have looked into this some more and I 've found that the solution I > > proposed is incomplete. > > > > The problem is that if no linker plugin is found, -fno-fat-lto-objects > > is not passed on, so the test isn't skipped and it will fail because - > > flto doesn't do assembly generation by default and the errors will not > > be triggered. > > > > This can be fixed by adding -ffat-lto-objects as a test option for error > > tests, as shown in the patch below. > > > > The thing is, this already happens for scan-assembler & friends behind- > > the-scenes, but not for dg-error, because the former are run through > > force_conventional_output, while the latter is not. > > > > A nicer solution would be to have a new directive which would do nothing > > except for the force_conventional_output part, thus forcing assembly > > generation, but this may be overkill. > > > > Regards, > > Toma > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/mips/msa-builtins-err.c (dg-options): Use > > -ffat-lto-objects to guarantee assembly generation. > > OK, thanks for investigating. Slight tweak to the changelog we just say > what changed in the changelog not why. You covered 'why' in the code > comment. This is just: > > (dg-options): Add -ffat-lto-objects option. > > Thanks, > Matthew
