On Mon, May 29, 2017 at 07:15:33PM +0300, Alexander Monakov wrote: > Hi, > > On Wed, 24 May 2017, Richard Biener wrote: > > current_pass might be NULL so you better do set_internal_error_hook when > > we start executing passes (I detest global singletons to do such stuff > > anyway). > > I think there are other problems in this patch, dump_function_to_file won't > work > after transition to RTL (it only handles GIMPLE). It's much better to just > use > existing dump routine in passes.c and use the existing diagnostic callbacks.
Your patch looks good to me. Thanks, -Andi
