On Mon, 29 May 2017, Alexander Monakov wrote: > On Mon, 29 May 2017, Jakub Jelinek wrote: > > Also, as none of the arguments are used and we are in C++, > > perhaps it should be > > static void > > internal_error_function (diagnostic_context *, const char *, va_list *) > > { > > ? > > Ah, it seems GCC tends to use either the long-winded form I've copy-pasted in > my > patch, or the slightly shorter variant with 'type_name ARG_UNUSED (arg_name)'. > The shorthand form you're pointing out seems to be used only once, in > vmsdbgout.c, as far as I can tell.
Scratch this, I totally botched my grep invocation. There's plenty of instances where the shorthand form is used, and I'll be happy to use it here as well. Alexander