Hi Tom!
On Thu, 28 Sep 2017 09:41:15 +0200, Tom de Vries <tom_devr...@mentor.com> wrote:
> On 11/07/2013 09:11 AM, Jakub Jelinek wrote:
> > On Wed, Nov 06, 2013 at 08:42:16PM +0100, tho...@codesourcery.com wrote:
> >> From: Thomas Schwinge <tho...@codesourcery.com>
> >>
> >> libgomp/
> >> * testsuite/lib/libgomp.exp (libgomp_init): Don't add -fopenmp to
> >> ALWAYS_CFLAGS.
> >> * testsuite/libgomp.c++/c++.exp (ALWAYS_CFLAGS): Add -fopenmp.
> >> * testsuite/libgomp.c/c.exp (ALWAYS_CFLAGS): Likewise.
> >> * testsuite/libgomp.fortran/fortran.exp (ALWAYS_CFLAGS): Likewise.
> >> * testsuite/libgomp.graphite/graphite.exp (ALWAYS_CFLAGS):
> >> Likewise.
Note that my patch just moved *where* the flag gets set, so...
> Following up on this, how about we drop the now superfluous -fopenmp in
> current test-cases?
... it has already been superfluous before. ;-)
Anyway: ACK conceptually.
> Tested on x86_64. Verified by analyzing libgomp.log that -fopenmp is
> still passed to test-cases as required.
>
> OK for trunk?
> --- a/libgomp/testsuite/libgomp.c++/for-12.C
> +++ b/libgomp/testsuite/libgomp.c++/for-12.C
> @@ -1,5 +1,3 @@
> -/* { dg-options "-fopenmp" } */
As far as I remember, this means that instead of "-fopenmp" the
"DEFAULT_CFLAGS" will then be used: "-O2", so this effectively changes
testing from "-O2" to "-O2". Same for a few other cases where you remove
"dg-options" altogether. Special consideration required for fortran,
which should never specify these in "dg-options" because it cycles
("torture testing") through different optimization flags.
With that fixed: Reviewed-by: Thomas Schwinge <tho...@codesourcery.com>
(See
<http://mid.mail-archive.com/87tvzuk29t.fsf@euler.schwinge.homeip.net>.)
But I can't formally approve, of course.
Grüße
Thomas
