On 09/28/2017 10:37 AM, Thomas Schwinge wrote:
Hi Tom!
On Thu, 28 Sep 2017 09:41:15 +0200, Tom de Vries <tom_devr...@mentor.com> wrote:
On 11/07/2013 09:11 AM, Jakub Jelinek wrote:
On Wed, Nov 06, 2013 at 08:42:16PM +0100, tho...@codesourcery.com wrote:
From: Thomas Schwinge <tho...@codesourcery.com>
libgomp/
* testsuite/lib/libgomp.exp (libgomp_init): Don't add -fopenmp to
ALWAYS_CFLAGS.
* testsuite/libgomp.c++/c++.exp (ALWAYS_CFLAGS): Add -fopenmp.
* testsuite/libgomp.c/c.exp (ALWAYS_CFLAGS): Likewise.
* testsuite/libgomp.fortran/fortran.exp (ALWAYS_CFLAGS): Likewise.
* testsuite/libgomp.graphite/graphite.exp (ALWAYS_CFLAGS):
Likewise.
Note that my patch just moved *where* the flag gets set, so...
Following up on this, how about we drop the now superfluous -fopenmp in
current test-cases?
... it has already been superfluous before. ;-)
Anyway: ACK conceptually.
Tested on x86_64. Verified by analyzing libgomp.log that -fopenmp is
still passed to test-cases as required.
OK for trunk?
--- a/libgomp/testsuite/libgomp.c++/for-12.C
+++ b/libgomp/testsuite/libgomp.c++/for-12.C
@@ -1,5 +1,3 @@
-/* { dg-options "-fopenmp" } */
As far as I remember, this means that instead of "-fopenmp" the
"DEFAULT_CFLAGS" will then be used: "-O2", so this effectively changes
testing from "-O2" to "-O2".
I think you mean from "-O0" to "-O2", but yes.
I was explicit about this in an earlier commit (
https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00487.html ), but forgot
again about it here.
Anyway, I think we only care about preserving explicit "-O0" settings,
so this should be ok.
With that fixed: Reviewed-by: Thomas Schwinge <tho...@codesourcery.com>
You just got the first review credits in the commit log since 2004 ;)
Thanks,
- Tom
