On 10/12/2017 05:58 PM, Ian Lance Taylor wrote:
> "Tsimbalist, Igor V" <igor.v.tsimbal...@intel.com> writes:
> 
>> Enable building libbacktrace with CET options.
>>
>> libbacktrace/
>>      * configure.ac: Add CET_FLAGS to EXTRA_FLAGS.
>>      * aclocal.m4: Regenerate.
>>      * Makefile.in: Likewise.
>>      * configure: Likewise.
> 
>> +if test x$enable_cet = xyes; then
>> +  CET_FLAGS="-fcf-protection -mcet -include cet.h"
>> +fi
> 
> Is this really right?  Why the -include option?  CET protection sounds
> like it should work for any language, but -include is C-specific and
> doesn't seem to have anything to do with code generation.
Agreed.  And more generally it seems that we want to be able to just use
the -f/-m options to enable/disable CET checking.  If we're having to
include additional files to get CET support, then we need to go back and
rethink things somewhere.

Jeff

Reply via email to