On Tue, Feb 20, 2018 at 09:51:14AM +0200, Janne Blomqvist wrote: > On Tue, Feb 20, 2018 at 12:41 AM, Thomas Koenig <tkoe...@netcologne.de> wrote: > > Hello world, > > > > when putting in a seemingly innocent simplification for PR 56342, > > I caused a regression in PR 82823, in PACK. The root cause of > > this one turned out to be PR 48890, in which structure > > constructors containing characters were not handled correctly > > if the lengths did not match. > > > > The attached patch fixes that. > > > > Regression-tested. OK for trunk? > > It's better to use gfc_mpz_get_hwi() instead of mpz_get_si(). > mpz_get_si() returns a long, which is a 32-bit type on win64. > > Otherwise Ok with the spelling fix suggested by Steve. >
Good catch. I don't know how I forgot that you've spent a lot time fixing int, long, size_t, ssize_t issues. -- Steve
