On Mon, Oct 1, 2018 at 1:27 PM, H.J. Lu <hjl.to...@gmail.com> wrote: > On Mon, Oct 1, 2018 at 1:18 PM, Ian Lance Taylor <i...@golang.org> wrote: >> On Wed, Sep 26, 2018 at 7:50 AM, H.J. Lu <hjl.to...@gmail.com> wrote: >>> On Mon, Sep 24, 2018 at 2:46 PM, Ian Lance Taylor <i...@golang.org> wrote: >>>> I've committed a patch to update libgo to the 1.11 release. As usual >>>> for these updates, the patch is too large to attach to this e-mail >>>> message. I've attached some of the more relevant directories. This >>>> update required some minor patches to the gotools directory and the Go >>>> testsuite, also included here. Bootstrapped and ran Go testsuite on >>>> x86_64-pc-linux-gnu. Committed to mainline. >>>> >>>> Ian >>>> >>>> 2018-09-24 Ian Lance Taylor <i...@golang.org> >>>> >>>> * Makefile.am (mostlyclean-local): Run chmod on check-go-dir to >>>> make sure it is writable. >>>> (check-go-tools): Likewise. >>>> (check-vet): Copy internal/objabi to check-vet-dir. >>>> * Makefile.in: Rebuild. >>> >>> When building with -mx32, I got >>> >>> /export/gnu/import/git/sources/gcc/libgo/go/runtime/malloc.go:309:44: >>> error: integer constant overflow >>> 309 | arenaBaseOffset uintptr = sys.GoarchAmd64 * (1 << 47) >>> | ^ >> >> >> Thanks. I fixed this problem by switching to using amd64p32 on x32. >> Bootstrapped and ran testsuite on x86_64-pc-linux-gnu using >> --with-multilib-list=m64,m32,mx32. However, I ran this on a kernel >> without x32 support, so while building succeeds, I couldn't actually >> run any tests. Let me know how they do. >> >> Ian > > I am giving it try. >
Compared with my patch, there are some new failures: --- FAIL: TestAtomicStop (1.82s) signal_test.go:384: iteration 5: output lost signal on tries: 2 signal_test.go:392: iteration 5: lost signal FAIL FAIL: os/signal FAIL: go.test/test/env.go execution, -O2 -g FAIL: go.test/test/nilptr2.go execution, -O2 -g FAIL: go.test/test/nilptr2.go execution, -O2 -g FAIL: net/http --- FAIL: TestExtraFiles (0.21s) exec_test.go:611: Run: exit status 1; stdout "leaked parent file. fd = 6; want 4\n", stderr "" FAIL FAIL: os/exec goroutine 4538 [runnable]: created by net_http_test.TestConcurrentServerServe /export/build/gnu/tools-build/gcc-x32/build-x86_64-linux/x86_64-pc-linux-gnu/32/libgo/gotest51963/test/serve_test.go:5394 +310 goroutine 4539 [runnable]: created by net_http_test.TestConcurrentServerServe /export/build/gnu/tools-build/gcc-x32/build-x86_64-linux/x86_64-pc-linux-gnu/32/libgo/gotest51963/test/serve_test.go:5395 +421 eax 0x0 ebx 0x2 ecx 0xa6cf6a5c edx 0x0 edi 0x0 esi 0x8 ebp 0xa6cf6a5c esp 0xa6cf6a40 eip 0xf7ed4069 eflags 0x282 cs 0x23 fs 0x0 gs 0x63 FAIL: net/http goroutine 23819 [GC worker (idle)]: runtime.mcall /export/gnu/import/git/sources/gcc/libgo/runtime/proc.c:342 runtime.gopark /export/build/gnu/tools-build/gcc-x32/build-x86_64-linux/x86_64-pc-linux-gnu/32/libgo/gotest93522/test/proc.go:333 runtime.gcBgMarkWorker /export/build/gnu/tools-build/gcc-x32/build-x86_64-linux/x86_64-pc-linux-gnu/32/libgo/gotest93522/test/mgc.go:1773 runtime.kickoff /export/build/gnu/tools-build/gcc-x32/build-x86_64-linux/x86_64-pc-linux-gnu/32/libgo/gotest93522/test/proc.go:1214 created by runtime.gcBgMarkStartWorkers /export/build/gnu/tools-build/gcc-x32/build-x86_64-linux/x86_64-pc-linux-gnu/32/libgo/gotest93522/test/mgc.go:1719 +92 eax 0x0 ebx 0x2 ecx 0xaa4ecaec edx 0x0 edi 0x0 esi 0x8 ebp 0xaa4ecaec esp 0xaa4ecad0 eip 0xf7f81069 eflags 0x286 cs 0x23 fs 0x0 gs 0x63 FAIL: runtime FAIL: go.test/test/env.go execution, -O2 -g FAIL: go.test/test/nilptr2.go execution, -O2 -g FAIL: go.test/test/nilptr2.go execution, -O2 -g -- H.J.