On Mon, Oct 1, 2018 at 5:06 PM, Ian Lance Taylor <i...@golang.org> wrote:
> On Mon, Oct 1, 2018 at 4:56 PM, H.J. Lu <hjl.to...@gmail.com> wrote:
>>
>> Compared with my patch, there are some new failures:
>
> Thanks. We probably need a patch in gcc/testsuite/go.test/go-test.exp
> to set goarch to amd64p32 when appropriate.
This is that patch. I figured out how to run x32 binaries on my
system. With this patch, everything passes except some code using
getpwuid_r, which also fails in plain C so I'm not going to worry
about it. That said, I do not see some of the failures you mentioned.
In any case, this patch does pass bootstrap and testing on
x86_64-pc-linux-gnu both with and without -mx32. Committed to
mainline.
Ian
2018-10-03 Ian Lance Taylor <i...@google.com>
* go.test/go-test.exp (go-set-goarch): Use amd64p32 on x32.
Index: go.test/go-test.exp
===================================================================
--- go.test/go-test.exp (revision 264816)
+++ go.test/go-test.exp (working copy)
@@ -203,6 +203,8 @@
"x86_64-*-*" {
if [check_effective_target_ia32] {
set goarch "386"
+ } elseif [check_effective_target_x32] {
+ set goarch "amd64p32"
} else {
set goarch "amd64"
}
