On Wed, 14 Nov 2018 15:41:00 +0000 Jozef Lawrynowicz <joze...@mittosystems.com> wrote:
> Patch 6 fixes tests expecting printf float support for targets which have been > configured with "newlib-nano-formatted-io". When newlib is configured in this > way, float printf is enabled at build time by registering _printf_float as an > undefined symbol. Added missing documentation for new check_effective target procs in attached patch.
>From ad5c2e3684904f961938cfc0b50445013300c6e0 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz <joze...@mittosystems.com> Date: Sat, 10 Nov 2018 16:02:25 +0000 Subject: [PATCH] [TESTSUITE] Fix tests requiring float printf support when GCC was configured with --enable-newlib-nano-formatted-io 2018-11-21 Jozef Lawrynowicz <joze...@mittosystems.com> gcc/ChangeLog: * doc/sourcebuild.texi: Document check_effective_target_newlib_nano_io. gcc/testsuite/ChangeLog: * lib/target-supports.exp (check_effective_target_newlib_nano_io): New. * gcc.c-torture/execute/920501-8.c: Register undefined linker symbol _printf_float for newlib_nano_io target. * gcc.c-torture/execute/930513-1.c: Likewise. * gcc.dg/torture/builtin-sprintf.c: Likewise. * gcc.c-torture/execute/ieee/920810-1.x: New. --- gcc/doc/sourcebuild.texi | 4 ++++ gcc/testsuite/gcc.c-torture/execute/920501-8.c | 2 ++ gcc/testsuite/gcc.c-torture/execute/930513-1.c | 2 ++ gcc/testsuite/gcc.c-torture/execute/ieee/920810-1.x | 4 ++++ gcc/testsuite/gcc.dg/torture/builtin-sprintf.c | 3 ++- gcc/testsuite/lib/target-supports.exp | 4 ++++ 6 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.c-torture/execute/ieee/920810-1.x diff --git a/gcc/doc/sourcebuild.texi b/gcc/doc/sourcebuild.texi index 9c57226..bfaa0fd 100644 --- a/gcc/doc/sourcebuild.texi +++ b/gcc/doc/sourcebuild.texi @@ -2152,6 +2152,10 @@ Target supports @code{mmap}. @item newlib Target supports Newlib. +@item newlib_nano_io +GCC was configured with @code{--enable-newlib-nano-formatted-io}, which reduces +the code size of Newlib formatted I/O functions. + @item pow10 Target provides @code{pow10} function. diff --git a/gcc/testsuite/gcc.c-torture/execute/920501-8.c b/gcc/testsuite/gcc.c-torture/execute/920501-8.c index 62780a0..7e4fa17 100644 --- a/gcc/testsuite/gcc.c-torture/execute/920501-8.c +++ b/gcc/testsuite/gcc.c-torture/execute/920501-8.c @@ -1,3 +1,5 @@ +/* { dg-additional-options "-Wl,-u,_printf_float" { target newlib_nano_io } } */ + #include <stdio.h> #include <stdarg.h> diff --git a/gcc/testsuite/gcc.c-torture/execute/930513-1.c b/gcc/testsuite/gcc.c-torture/execute/930513-1.c index 4544471..f163007 100644 --- a/gcc/testsuite/gcc.c-torture/execute/930513-1.c +++ b/gcc/testsuite/gcc.c-torture/execute/930513-1.c @@ -1,3 +1,5 @@ +/* { dg-additional-options "-Wl,-u,_printf_float" { target newlib_nano_io } } */ + #include <stdio.h> char buf[2]; diff --git a/gcc/testsuite/gcc.c-torture/execute/ieee/920810-1.x b/gcc/testsuite/gcc.c-torture/execute/ieee/920810-1.x new file mode 100644 index 0000000..8edec730 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/ieee/920810-1.x @@ -0,0 +1,4 @@ +if { [check_effective_target_newlib_nano_io] } { + lappend additional_flags "-Wl,-u,_printf_float" +} +return 0 diff --git a/gcc/testsuite/gcc.dg/torture/builtin-sprintf.c b/gcc/testsuite/gcc.dg/torture/builtin-sprintf.c index 6f8b7a9..5684fd7 100644 --- a/gcc/testsuite/gcc.dg/torture/builtin-sprintf.c +++ b/gcc/testsuite/gcc.dg/torture/builtin-sprintf.c @@ -1,6 +1,7 @@ /* PR tree-optimization/86274 - SEGFAULT when logging std::to_string(NAN) { dg-do run } - { dg-options "-O2 -Wall" } */ + { dg-options "-O2 -Wall" } + { dg-additional-options "-Wl,-u,_printf_float" { target newlib_nano_io } } */ #define X "0xdeadbeef" #define nan(x) __builtin_nan (x) diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 7488653..d696fc6 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -6691,6 +6691,10 @@ proc check_effective_target_newlib {} { #include <newlib.h> }] } +# Return true if GCC was configured with --enable-newlib-nano-formatted-io +proc check_effective_target_newlib_nano_io { } { + return [check_configured_with "--enable-newlib-nano-formatted-io"] +} # Some newlib versions don't provide a frexpl and instead depend # on frexp to implement long double conversions in their printf-like -- 2.7.4