Ok for google/main after compiler bootstrap and regression test (without ftsan), and some large tests with tsan turned on (as many as you can but at your discretion).
David On Sun, Nov 13, 2011 at 11:59 PM, <dvyu...@google.com> wrote: > On 2011/11/11 00:00:35, davidxl wrote: >> >> Have you run through SPEC, and SPEC06 with this change? What is the >> instrumentation overhead using gcc? > >> David > > No, I don't use SPEC for testing and benchmarking. For testing I use a > pair of large tests in you-know-what codebase. As for benchmarking, > overheads are dominated by runtime processing, moderate variations in > instrumentation have negligible effect. As of now I would be happy to > make it correct and finally commit, probably I spent a way too much time > on optimizations already so now it's hard to make it correct and commit. > > > http://codereview.appspot.com/5303083/ >
