On Mon, 2 Dec 2019 15:43:29 +0100
Thomas Schwinge <tho...@codesourcery.com> wrote:
> > --- a/libgomp/openacc.h
> > +++ b/libgomp/openacc.h
> > @@ -55,6 +55,7 @@ typedef enum acc_device_t {
> > /* acc_device_host_nonshm = 3 removed. */
> > acc_device_not_host = 4,
> > acc_device_nvidia = 5,
> > + acc_device_gcn = 8,
>
> There is no 'acc_device_gcn' in OpenACC. Per OpenACC 3.0, A.1.2. "AMD
> GPU Targets", for example, there is 'acc_device_radeon' (and "the
> case-insensitive name 'radeon' for the environment variable
> 'ACC_DEVICE_TYPE'"). If that is not appropriate to use (I have not
> read up how exactly AMD's "GCN" and "radeon" relate to each other),
> we should get that clarified in the OpenACC specification.
FWIW, I'm pretty sure there are Radeon devices that do not use the GCN
ISA. OTOH, there are also Nvidia devices that are not PTX-compatible.
No strong opinion on the acc_device_foo name from me, though (maybe
"acc_device_amdgcn"?).
Julian
