On Wed, Mar 04, 2020 at 03:08:41PM +0800, binbin wrote: > >> * config/rs6000/rs6000.h (MAX_MACHINE_MODE): Include the header file > >> for MAX_MACHINE_MODE. > > > >The changelog entry should say *what* file is included, and under what > >condition. It doesn't have to say why (that belongs in the commit > >message). > > > >But, can't you just include it unconditionally? Don't we already, > >anyway, via coretypes.h -> machmode.h -> insn-modes.h? > > OK, change it to uncondition. Thanks for your suggestion.
What about the second part? Shouldn't it already be included anyway? > * config/rs6000/rs6000-internal.h (altivec_builtin_mask_for_load, > builtin_mode_to_type[MAX_MACHINE_MODE][2]): Remove GTY(()). This changelog entry needs updating now. (And please check the rest as well.) Segher
