Hi,

On 2020/3/10 上午10:30, binbin wrote:
Hi,

On 2020/3/9 下午10:32, Segher Boessenkool wrote:
Hi!

On Mon, Mar 09, 2020 at 01:58:01PM +0800, binbin wrote:
2020-03-09  Bin Bin Lv  <s...@linux.ibm.com>

    * config/rs6000/rs6000-internal.h (altivec_builtin_mask_for_load,
    builtin_mode_to_type[MAX_MACHINE_MODE][2]): Remove the declaration.

Just write "builtin_mode_to_type", nothing []?  Writing down the
dimensions here doesn't add anything, just is a bit noisy: you normally
put just the name here.

OK, modified.  Thanks.


    * config/rs6000/rs6000.c (altivec_builtin_mask_for_load,
    builtin_mode_to_type[MAX_MACHINE_MODE][2]): Remove the GTY(())
    declaration and add the definition.

The definitions were already there, so lose the second part of this?

OK, removed.  Thanks.


diff --git a/gcc/config/rs6000/rs6000.h b/gcc/config/rs6000/rs6000.h
index 1697186..724085b 100644
--- a/gcc/config/rs6000/rs6000.h
+++ b/gcc/config/rs6000/rs6000.h
@@ -2490,6 +2490,8 @@ extern GTY(()) tree rs6000_builtin_types[RS6000_BTI_MAX];
  extern GTY(()) tree rs6000_builtin_decls[RS6000_BUILTIN_COUNT];
  #ifndef USED_FOR_TARGET
+extern GTY(()) tree builtin_mode_to_type[MAX_MACHINE_MODE][2];
+extern GTY(()) tree altivec_builtin_mask_for_load;

Add a newline here please?

OK, added a newline.  Thanks.


  /* A C structure for machine-specific, per-function data.
     This is added to the cfun structure.  */
  typedef struct GTY(()) machine_function

Okay for trunk with those tweaks.  Thanks!


Segher


Submitted the patch.

Reply via email to