On Thu, 14 May 2020, Jeff Law wrote: >> OK to commit? > OK. In fact, this seems like you shouldn't need reviews -- you're just > updating the docs for D.
Agreed, though always happy to help and provide review and feedback - sometimes just a bit slow as in this case. But, indeed, you can self approve, Iain. Here is some specific feedback on the patch: + <li>Aliases can now be created directly from any <code>__trait</code> that + return symbols or tuples. Previously, an <code>AliasSeq</code> was "returns" ? + <li>It is now possible to detect the language ABI specified for a struct, + class, or interface using <code>__traits(getLinkage, ...)</code> Full stop. + <li>Support for <code>core.math.toPrec</code> intrinsics have been added. "has been" + These intrinsics guarantee the rounding to specific floating-point + precisions at required points in the code. Is this about required points (by the standard) or specified (by the user/programmer)? + <li>Optional parentheses in <code>asm</code> operands are now deprecated and + will be removed in a future release. Maybe omit "now" of which there's a number in the vicinity already? + <li>Added <code>--enable-libphobos-checking</code> configure option to "Added a..."? + <li>Added <code>--with-libphobos-druntime-only</code> configure option to Same here? + allow specifying whether to build only the core D runtime library, or + both the core and standard libraries into libphobos. This reads a bit complicated. Maybe "option to indicate whether to build..." ? Please consider those items and questions and share the patch as you'll install it - no need for review or anything. :) Thanks, Gerald
