On 14/05/2020 17:04, Gerald Pfeifer wrote:
> On Thu, 14 May 2020, Jeff Law wrote:
>>> OK to commit?
>> OK.  In fact, this seems like you shouldn't need reviews -- you're just 
>> updating the docs for D.
> 
> Agreed, though always happy to help and provide review and feedback
> - sometimes just a bit slow as in this case.  But, indeed, you can
> self approve, Iain.
> 
> 
> Here is some specific feedback on the patch:
>  
> +  <li>Aliases can now be created directly from any <code>__trait</code> that
> +      return symbols or tuples.  Previously, an <code>AliasSeq</code> was
> 
> "returns" ?
> 

The "s" should instead be on:

"<code>__traits</code> that return symbols or tuples."

I don't *think* "returns" is necessary, there's already a plethora of plurals.
To be sure though, I put it through a grammar checker, and it flags up "returns"
as an error of subject-verb agreement in the sentence.

> +  <li>It is now possible to detect the language ABI specified for a struct,
> +      class, or interface using <code>__traits(getLinkage, ...)</code>
> 
> Full stop.
> 
> +  <li>Support for <code>core.math.toPrec</code> intrinsics have been added.
> 
> "has been"
> 
> +      These intrinsics guarantee the rounding to specific floating-point
> +      precisions at required points in the code.
> 
> Is this about required points (by the standard) or specified (by the 
> user/programmer)?
> 

By user/programmer, so I've changed it to "specified".

> +  <li>Optional parentheses in <code>asm</code> operands are now deprecated 
> and
> +      will be removed in a future release.
> 
> Maybe omit "now" of which there's a number in the vicinity already?
> 
> +  <li>Added <code>--enable-libphobos-checking</code> configure option to
> 
> "Added a..."?
> 
> +  <li>Added <code>--with-libphobos-druntime-only</code> configure option to
> 
> Same here?
> 
> +      allow specifying whether to build only the core D runtime library, or
> +      both the core and standard libraries into libphobos.
> 
> This reads a bit complicated.  Maybe "option to indicate whether to 
> build..." ?
> 
> 
> Please consider those items and questions and share the patch as you'll
> install it - no need for review or anything. :)
> 


Installed.

diff --git a/htdocs/gcc-10/changes.html b/htdocs/gcc-10/changes.html
index 8eaa3326..b9fae2c6 100644
--- a/htdocs/gcc-10/changes.html
+++ b/htdocs/gcc-10/changes.html
@@ -497,6 +497,41 @@ int get_naïve_pi() {
   </li>
 </ul>
 
+<h3 id="d">D</h3>
+<ul>
+  <li>Support for <code>static foreach</code> has been implemented.</li>
+  <li>Aliases can now be created directly from any <code>__traits</code> that
+      return symbols or tuples.  Previously, an <code>AliasSeq</code> was
+      necessary in order to alias their return.
+  </li>
+  <li>It is now possible to detect the language ABI specified for a struct,
+      class, or interface using <code>__traits(getLinkage, ...)</code>.
+  <li>Support for <code>core.math.toPrec</code> intrinsics has been added.
+      These intrinsics guarantee the rounding to specific floating-point
+      precisions at specified points in the code.
+  </li>
+  <li>Support for <code>pragma(inline)</code> has been implemented.  Previously
+      the pragma was recognized, but had no effect on the compilation.
+  </li>
+  <li>Optional parentheses in <code>asm</code> operands are deprecated and will
+      be removed in a future release.
+  </li>
+  <li>All content imported files are now included in the make dependency list
+      when compiling with <code>-M</code>.
+  </li>
+  <li>Compiler recognized attributes provided by the <code>gcc.attribute</code>
+      module will now take effect when applied to function prototypes as well
+      as when applied to full function declarations.
+  </li>
+  <li>Added a <code>--enable-libphobos-checking</code> configure option to
+      control whether run-time checks are compiled into the D runtime library.
+  </li>
+  <li>Added a <code>--with-libphobos-druntime-only</code> configure option to
+      indicate whether to build only the core D runtime library, or both the
+      core and standard libraries into libphobos.
+  </li>
+</ul>
+
 <h3 id="fortran">Fortran</h3>
 <ul>
   <li><code>use_device_addr</code> of version 5.0 of the



Reply via email to