On 10/12/20 11:14 -0600, Peter Bergner via Libstdc++ wrote:
On 12/10/20 10:14 AM, Jonathan Wakely wrote:
On 04/12/20 00:35 +0000, Jonathan Wakely wrote:
On 03/12/20 20:07 -0300, Tulio Magno Quites Machado Filho via Libstdc++ wrote:
I suggest to replace frexpf128 with __frexpieee128.
The former is available on a glibc that support _Float128 (since glibc 2.26).
The later is available on a glibc that supports binary128 long double (since
glibc 2.32)
Hmm, yes, you pointed me to __frexpieee128 a few months ago, but for
some reason I either didn't switch to using it, or lost a patch when
squashing and rebasing branches. Hopefully I just forgot to change it,
but I'll double check to make sure I haven't left any work on an old
branch. Thanks for suggesting it (again!)
As expected, it still works with a check for __frexpieee128 instead.
So are you happy for me to push this to master with that change?
(It won't be until Tuesday now, as I have some time off).
FYI, Tulio is on vacation through December 22nd and I'm not sure how
closely he is watching his email, if at all. Given Tulio mentioned
the change in the first place, I think he's ok with the change.
He can beat me later if I'm wrong! :-)
The question was more about pushing the entire patch for ieee128
support, which isn't on master yet.
Do we want this done now for gcc 11? It adds a ton of new symbols to
libstdc++.so which would be a pain to remove again if we decide it's
not ready.
Currently the new features will be enabled by default if the support
is detected in the compiler and glibc. Do we want to gate it behind a
new --enable-something-something option? (I'm assuming not).
