On Tue, Apr 13, 2021 at 05:19:12PM -0500, Segher Boessenkool wrote: > Hi! > > On Fri, Apr 09, 2021 at 10:42:50AM -0400, Michael Meissner wrote: > > Since then the patch seems to have gone into a limbo state. > > Patches I cannot immediately handle take time, and if they aren't > pinged, they can fall off the map. So a) ping your patches, once a week > for example; and b) write patches that are simpler to review (do not > cost many hours each). > > > gcc/ > > 2021-04-09 Michael Meissner <meiss...@linux.ibm.com> > > > > * config/rs6000/rs6000.c (rs6000_emit_minmax): Add support for ISA > > 3.1 IEEE 128-bit floating point xsmaxcqp and xsmincqp instructions. > > * config/rs6000/rs60000.h (FLOAT128_MIN_MAX_FPMASK_P): New macro. > > As said in the other mail, don't do the macro; just write its expansion > in the single place it is used.
Note, in the first patch it is only used 1 time, but in the second patch it is used 5 times (4 times in mode iterators in rs6000.md, 1 other use in rs6000.c). But I will eliminate it, and replicate it in each of the 6 places it is used. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.ibm.com, phone: +1 (978) 899-4797