On Wed, Apr 14, 2021 at 02:15:47PM -0500, Segher Boessenkool wrote: > On Wed, Apr 14, 2021 at 03:09:13PM -0400, Michael Meissner wrote: > > On Tue, Apr 13, 2021 at 05:19:12PM -0500, Segher Boessenkool wrote: > > > > * config/rs6000/rs60000.h (FLOAT128_MIN_MAX_FPMASK_P): New > > > > macro. > > > > > > As said in the other mail, don't do the macro; just write its expansion > > > in the single place it is used. > > > > Note, in the first patch it is only used 1 time, but in the second patch it > > is > > used 5 times (4 times in mode iterators in rs6000.md, 1 other use in > > rs6000.c). > > But I will eliminate it, and replicate it in each of the 6 places it is > > used. > > The alternative is to come up with a much better name :-/
I dunno, given the what the macro is used for (i.e. whether we have the IEEE 128-bit minimum, maximum, and floating point compare mask) FLOAT128_MIN_MAX_FPMASK_P meets the definition. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.ibm.com, phone: +1 (978) 899-4797
