On Tue, May 18, 2021 at 04:26:06PM -0400, Michael Meissner wrote:
> This patch adds the support for the IEEE 128-bit floating point C minimum and
> maximum instructions.
> gcc/
> 2021-05-18 Michael Meissner <meiss...@linux.ibm.com>
>
> * config/rs6000/rs6000.c (rs6000_emit_minmax): Add support for ISA
> 3.1 IEEE 128-bit floating point xsmaxcqp and xsmincqp
> instructions.
3.1 fits on the previous line (it is better to not split numbers to a
new line). What is up with the weird multiple spaces? We don't align
the right border in changelogs :-)
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/powerpc/float128-minmax-2.c
> @@ -0,0 +1,15 @@
> +/* { dg-require-effective-target ppc_float128_hw } */
> +/* { dg-require-effective-target power10_ok } */
Is this needed? And, why is ppc_float128_hw needed? That combination
does not seem to make sense.
> --- a/gcc/testsuite/gcc.target/powerpc/float128-minmax.c
> +++ b/gcc/testsuite/gcc.target/powerpc/float128-minmax.c
> @@ -3,6 +3,13 @@
> /* { dg-require-effective-target float128 } */
> /* { dg-options "-mpower9-vector -O2 -ffast-math" } */
>
> +/* If the compiler was configured to automatically generate power10 support
> with
> + --with-cpu=power10, turn it off. Otherwise, it will generate XXMAXCQP and
> + XXMINCQP instructions. */
> +#ifdef _ARCH_PWR10
> +#pragma GCC target ("cpu=power9")
> +#endif
Yeah, don't. Add a dg-skip-if if that is what you want. That
-mpower9-vector shouldn't be there either.
Segher
