On Mon, Jun 07, 2021 at 03:25:06PM -0500, Segher Boessenkool wrote: > On Tue, May 18, 2021 at 04:26:06PM -0400, Michael Meissner wrote: > > This patch adds the support for the IEEE 128-bit floating point C minimum > > and > > maximum instructions. > > > gcc/ > > 2021-05-18 Michael Meissner <meiss...@linux.ibm.com> > > > > * config/rs6000/rs6000.c (rs6000_emit_minmax): Add support for ISA > > 3.1 IEEE 128-bit floating point xsmaxcqp and xsmincqp > > instructions. > > 3.1 fits on the previous line (it is better to not split numbers to a > new line). What is up with the weird multiple spaces? We don't align > the right border in changelogs :-) > > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/powerpc/float128-minmax-2.c > > @@ -0,0 +1,15 @@ > > +/* { dg-require-effective-target ppc_float128_hw } */ > > +/* { dg-require-effective-target power10_ok } */ > > Is this needed? And, why is ppc_float128_hw needed? That combination > does not seem to make sense.
Basically it is there to make sure that we are actually generating IEEE 128-bit instructions. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.ibm.com, phone: +1 (978) 899-4797