On 13/10/2021 13:37, Kyrylo Tkachov wrote:
Hi Andre,


@@ -24276,7 +24271,7 @@ arm_print_operand (FILE *stream, rtx x, int code)
        else if (code == POST_MODIFY || code == PRE_MODIFY)
          {
            asm_fprintf (stream, "[%r", REGNO (XEXP (addr, 0)));
-           postinc_reg = XEXP ( XEXP (x, 1), 1);
+           postinc_reg = XEXP (XEXP (addr, 1), 1);
            if (postinc_reg && CONST_INT_P (postinc_reg))
              {
                if (code == POST_MODIFY)

this looks like a bug fix that should be separately backported to the branches?
Otherwise, the patch looks ok for trunk to me.
Thanks,
Kyrill

Normally I'd agree with you, but this is specific for the 'E' handling, which is MVE only and I am pretty sure the existing code would never accept POST/PRE Modify codes so this issue will never trigger before my patch.So I'm not sure it's useful to backport a bugfix for a bug that won't trigger, unless we also backport the entire patch, but I suspect we don't want to do that?

Reply via email to