On 11/22/2021 1:45 AM, Richard Biener via Gcc-patches wrote:
On Fri, Nov 19, 2021 at 11:33 PM Navid Rahimi <navidrah...@microsoft.com> wrote:
Hi Richard,
Thanks for the detailed comment. I am attaching a newer version of the patch
which does have required fixes included. Bellow you can see my response to your
feedbacks:
you need to check TYPE_OVERFLOW_WRAPS on TREE_TYPE (@0),
otherwise you check on boolean.
Fixed it.
no need for :c on the result pattern. Otherwise it looks OK, but how
did you check the patch?
Fixed it. For checking the patch, I have script which builds and runs make
check for 1) trunk and 2) trunk+patch in a separate directory and diffs the
test results from each directory. My test script did had a subtle problem. The
bug was, because of a typo in the path I introduced few days ago, it was
diffing same trunk+patch test results against trunk+patch test results.
OK, please indicate that in the future, like with "Bootstrapped and
tested on x86_64-linux" or so.
That was a good reminder to setup an account for myself here asap [1].
1) https://gcc.gnu.org/wiki/CompileFarm
The updated patch is OK.
I don't think Navid has commit privs, so I fixed up the commit message
and committed the patch for Navid.
jeff
