On Thu, 23 Jun 2022 at 13:36, Alexandre Oliva <ol...@adacore.com> wrote: > > On Jun 23, 2022, Jonathan Wakely <jwak...@redhat.com> wrote: > > > Could this new arg be given a default value, so every caller doesn't > > have to pass "" to it? > > > proc v3_check_preprocessor_condition { name cond {inc ""} } { > > Oh, nice, I didn't know about this convenient notation for default args > in tcl, and the one I knew about I found too cumbersome. Thanks for the > tip, I put it in the patch below. > > > #ifndef _GLIBCXX_HAVE_SYMLINK > > And this too. > > > And if the definition of NO_SYMLINKS gets more complicated in future > > (e.g. we add something like && !defined __foo__) then using > > NO_SYMLINKS in the dg proc will keep them in sync. > > 'zactly my thinking. > > > Here's what I'm testing (same way). Ok to install if it passes?
Yes please, thanks for iterating to get this here.