Hi! On Thu, Aug 18, 2022 at 10:12:48AM +0800, Kewen.Lin wrote: > As PR99888 and its related show, the current support for > -fpatchable-function-entry on powerpc ELFv2 doesn't work > well with global entry existence.
> + /* Emit the NOPs after local entry. */ Please do not say "NOPs". It is not an acronym. I know some of our documentation has this bug already, but please do not spread it further. The machine instruction is "nop", lowercase. Please fix this. So, this patch overloads the meaning of the two parameters here to have more meaning than explained in the documentation for the option. There isn't much that can be done about this, so adding some new option would only be extra work for everyone. But, could you add a line or two in the documentation? "For PowerPC with the ELFv2 ABI, there will be M nops before the local entry point, and N-M after", something like that? Segher
